Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-translations): correct label for tip admonition in italian #10051

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix(theme-translations): correct label for tip admonition in italian #10051

merged 1 commit into from
Apr 18, 2024

Conversation

tomsotte
Copy link
Contributor

@tomsotte tomsotte commented Apr 17, 2024 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I've noticed the translation in italian for the Tip admonition is wrong, probably due to a lack of context when translating, as "tip" is more like a suggestion, a hint, instead of a tip for the waiter.

Test Plan

No tests changes.

Test links

Deploy preview: https://deploy-preview-10051--docusaurus-2.netlify.app/

Related issues/PRs

No.

@facebook-github-bot
Copy link
Contributor

Hi @tomsotte!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify Netlify
Copy link

netlify bot commented Apr 17, 2024

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 50f6594
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/661fdd0f7dd5bc0008fc26b7
😎 Deploy Preview https://deploy-preview-10051--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 36 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🔴 48 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 65 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 57 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 66 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

@tomsotte tomsotte changed the title fix(theme-translations): correct label for tip in italian fix(theme-translations): correct label for tip admonition in italian Apr 17, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 17, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@slorber
Copy link
Collaborator

slorber commented Apr 18, 2024

😄 thanks

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Apr 18, 2024
@slorber slorber merged commit 4772b27 into facebook:main Apr 18, 2024
31 checks passed
@somixyz somixyz mentioned this pull request May 24, 2024
Merged
This was referenced May 24, 2024
Closed
Merged
This was referenced May 25, 2024
Closed
Closed
Closed
This was referenced May 25, 2024
Merged
Open
Open
This was referenced May 26, 2024
Closed
Closed
Closed
This was referenced May 26, 2024
Open
Open
Open
Open
This was referenced May 27, 2024
Open
Open
@ramzimalhas ramzimalhas mentioned this pull request Aug 21, 2024
Open
This was referenced Aug 27, 2024
Open
Open
Open
Open
Open
@Ramyromel Ramyromel mentioned this pull request Aug 28, 2024
Merged
@Herychukwu Herychukwu mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 3, 2024
Open
Open
This was referenced Sep 4, 2024
Closed
Closed
Closed
@Exkaleburx Exkaleburx mentioned this pull request Sep 5, 2024
Open
This was referenced Sep 8, 2024
Closed
Closed
This was referenced Sep 11, 2024
Open
Open
Open
@qdraw qdraw mentioned this pull request Sep 14, 2024
Closed
@Exkaleburx Exkaleburx mentioned this pull request Sep 19, 2024
Open
@qdraw qdraw mentioned this pull request Sep 21, 2024
Closed
@galopeian1 galopeian1 mentioned this pull request Sep 26, 2024
Open
This was referenced Sep 28, 2024
Closed
Closed
This was referenced Oct 4, 2024
Open
Open
Open
@Abuchtela Abuchtela mentioned this pull request Nov 10, 2024
Open
@diegoazh diegoazh mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomsotte @facebook-github-bot @slorber